Review

Detector:	MuDetectOPAL_180330_1
Target:	project 'synthetic' version wait-loop
Misuse:	misuse 'wait-loop'

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	Object.wait() should be called in a loop that iteratively checks the condition waited for.
Fix Description:	Check condition in a loop.
Violation Types:	missing/iteration
In File:	WaitMisuse.java
In Method:	misuse(Target)
Code with Misuse:	`class WaitMisuse { void misuse(Target t) throws InterruptedException { synchronized (t) { if (t.isAvailable()) { t.wait(); } // Perform action appropriate to condition } } }`
Code with Pattern(s):	`public class WaitLoop { void pattern(Target t) throws InterruptedException { synchronized (t) { while (t.isAvailable()) { t.wait(); } // Perform action appropriate to condition } } }`

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping	Violation Types
Yes	0	1	no ranking	* synthetic/wait-loop/patterns-src/wait-loop/WaitLoop.java#pattern(Target)	1			missing/iteration

Reviewer Name:	rossana
Comment: