Review

Detector:	MuDetectOPAL_180217
Target:	project 'synthetic' version repetitive
Misuse:	misuse 'repetitive'

Misuse Details

Details about the known misuse from the MUBench dataset.

Description:	Loops over a collection, only to ensure it is not empty (every subsequent iteration performs the exact same computation).
Fix Description:	Replace the loop with a check.
Violation Types:	superfluous/iteration
In File:	Repetitive.java
In Method:	misuse(Collection)
Code with Misuse:	`class Repetitive { public String misuse(Collection<Object> objects) { String value = null; for (Object object : objects) { value = objects.iterator().next().toString(); } return value; } }`
Code with Pattern(s):	`public class OnlyOnce { void pattern(Collection<Object> objects) { if (!objects.isEmpty()) { objects.iterator().next(); } } }`

Potential Hits

Findings of the detector that identify an anomaly in the same file and method as the known misuse.

Hit	Rank	Confidence	Confidence String	Pattern Examples	Pattern Support	Pattern Violation	Target Environment Mapping	Violation Types
Yes	0	1	no ranking	* synthetic/repetitive/patterns-src/repetitive/OnlyOnce.java#pattern(Collection)	1			superfluous/iteration
No	1	1	no ranking	* synthetic/repetitive/patterns-src/repetitive/OnlyOnce.java#pattern(Collection)	1			superfluous/iteration

Reviewer Name:	rossana
Comment: